search

knative-extensions / backstage-plugins

Knative plugins for Backstage.
Apache License 2.0
2 stars 17 forks source link

Handle pagination when there are many components that are matched by the EventType consumer Backstage id #28

Closed aliok closed 4 months ago

aliok commented 5 months ago

During https://github.com/knative-extensions/backstage-plugins/pull/24, I've added code to fetch the consumers of an eventType. This fetch operation is done using the Backstage catalog api.

Currently, the code doesn't take care of the pagination if there are more than 1 page of components that are matched by the query criteria.

See https://github.com/knative-extensions/backstage-plugins/blob/408beed6455b648286e4873647a859fd150cdd94/backstage/plugins/knative-event-mesh-backend/src/providers/knativeEventMeshProcessor.ts#L102-L111

Tasks:

ahmetcihank commented 4 months ago

/assign

ahmetcihank commented 4 months ago

In documentation; https://backstage.io/docs/features/software-catalog/software-catalog-api/#get-entitiesby-query The limit number of entities returned per page is 20(by default).

We will use that default number and not provide any limit per page/batch.

aliok commented 4 months ago

/close

Fixed by #43

knative-prow[bot] commented 4 months ago

@aliok: Closing this issue.

In response to [this](https://github.com/knative-extensions/backstage-plugins/issues/28#issuecomment-1983159944): >/close > >Fixed by #43 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.