Introduce linter for Typescript code

knative-extensions / backstage-plugins

Knative plugins for Backstage.

Apache License 2.0

2 stars 17 forks source link

Introduce linter for Typescript code #32

Closed aliok closed 3 months ago

aliok commented 5 months ago

Typescript code is not linted currently.

Notes:

We already have lint scripts in package.json:

https://github.com/knative-extensions/backstage-plugins/blob/84b0e1c7fd01c3e34e4e48682cd04c3afa2ce6d7/backstage/package.json#L22-L23

Not sure what lint and lint:all do. Need to understand the difference and pick the correct one.
Introduce new CI action (in https://github.com/knative-extensions/backstage-plugins/tree/main/.github/workflows) to run the linter.
Also, adapt existing GitHub actions (release and release-snapshot) to run the linter

So, we should have a separate linter action that is to be run in every PR AND we should also run the linter in the release actions as we double check everything when we release.

VamshiReddy02 commented 4 months ago

Can I work on this issue?

Leo6Leo commented 4 months ago

/assign @VamshiReddy02

ahmetcihank commented 4 months ago

/assign

ahmetcihank commented 4 months ago

I am intentioanally breaking lint ; in order to test yarn backstage-cli repo lint --since origin/main script .. No matter how many times i tried, i am getting successfull lint builld.. This one is yarn backstage-cli repo lint, is checking lint for all the project .. @aliok

aliok commented 3 months ago

@ahmetcihank let's start with using lint:all(backstage-cli repo lint)? If we get answers from Backstage community about the --since origin/main part and understand why it isn't working, we can switch using that later on.

What do you think?

ahmetcihank commented 3 months ago

@aliok sounds good, thanks a lot. I am assuming there is something about packages , which i couldn't figure out .

aliok commented 3 months ago

/close Fixed by https://github.com/knative-extensions/backstage-plugins/pull/48

knative-prow[bot] commented 3 months ago

@aliok: Closing this issue.

In response to [this](https://github.com/knative-extensions/backstage-plugins/issues/32#issuecomment-2029330833): >/close >Fixed by https://github.com/knative-extensions/backstage-plugins/pull/48 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.