knative-extensions / backstage-plugins

Knative plugins for Backstage.
Apache License 2.0
3 stars 19 forks source link

Upgrade Node.js 18.x to 20.x #36

Closed shivam-sharma7 closed 7 months ago

shivam-sharma7 commented 7 months ago

Changes

Upgrade Node.js 18.x to 20.x

-

/kind

Fixes #

Release Note

Docs

knative-prow[bot] commented 7 months ago

@shivam-sharma7: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/knative-extensions/backstage-plugins/pull/36): > > > > ># Changes > > >Upgrade Node.js 18.x to 20.x >- >- >- > > >/kind > > >Fixes # > > > >**Release Note** > > >```release-note > >``` > >**Docs** > > >```docs > >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
knative-prow[bot] commented 7 months ago

Welcome @shivam-sharma7! It looks like this is your first PR to knative-extensions/backstage-plugins 🎉

aliok commented 7 months ago

/hold

The reason we have Node 18 is that Janus community also uses the same version: https://github.com/janus-idp/backstage-plugins/blob/main/.nvmrc

If that's ok, I want to hold this PR and check with them. They're extending Backstage and I think they have a better context than I do.

UPDATE: @shivam-sharma7 let's keep that this on hold, at least until I publish a demo (working on it).

knative-prow[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shivam-sharma7

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment