search

knative-extensions / backstage-plugins

Knative plugins for Backstage.
Apache License 2.0
3 stars 19 forks source link

linting actions added #48

Closed ahmetcihank closed 8 months ago

ahmetcihank commented 8 months ago

in terms of #32 linting actions are added in pr&release steps

ahmetcihank commented 8 months ago

apologies there is a mistake , i am gonna re open.

ahmetcihank commented 8 months ago

I did some refactoring in order to fix linting issues, however i can revert @aliok

aliok commented 8 months ago

@ahmetcihank looks great!

The linter action is complaining though 😄 , which shows it is working fine, though need to fix the linting issues

aliok commented 8 months ago

/lgtm /approve

Great job, thanks @ahmetcihank

aliok commented 8 months ago

Fixes #32

knative-prow[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetcihank, aliok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/backstage-plugins/blob/main/OWNERS)~~ [aliok] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment