knative-extensions / backstage-plugins

Knative plugins for Backstage.
Apache License 2.0
3 stars 17 forks source link

Import code from personal repositories #7

Closed aliok closed 7 months ago

aliok commented 7 months ago

/kind

Fixes #

Release Note

Docs

knative-prow[bot] commented 7 months ago

@aliok: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/knative-extensions/backstage-plugins/pull/7): >- Import code from personal repositories >- Initial working setup that shows eventTypes and brokers > > >/kind > > >Fixes # > > > >**Release Note** > > >```release-note > >``` > >**Docs** > > >```docs > >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
knative-prow[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/backstage-plugins/blob/main/OWNERS)~~ [aliok] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
github-advanced-security[bot] commented 7 months ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

jarias-lfx commented 7 months ago

/easycla

matzew commented 7 months ago

/lgtm

aliok commented 7 months ago

However, I wasn't able to see the frontend plugin - was I missing how to do that or is loading that going to be part of a future PR?

The plugin is registering a provider. So, if you have some event types and brokers in your Knative eventing installation, you will see them in Backstage API and Component views.

Sorry I didn't write these in the description.