search

knative-extensions / backstage-plugins

Knative plugins for Backstage.
Apache License 2.0
3 stars 19 forks source link

Slack notification will be sent when NPM publish process finished #70

Closed Leo6Leo closed 3 months ago

Leo6Leo commented 5 months ago

Fixes #14

Changes

Release Note

Slack notification will be sent when NPM publish process finished

May need help on setting the environment variables.

/cc @aliok @dsimansk

Leo6Leo commented 5 months ago

/hold unhold until the environmental variables are being set and the workflow works properly.

dsimansk commented 5 months ago

/hold unhold until the environmental variables are being set and the workflow works properly.

If this is only about SLACK_WEBHOOK. It's org wide env var, no worries.

Leo6Leo commented 4 months ago

/cc @aliok /unhold we can merge it to test it out

aliok commented 4 months ago

@Leo6Leo merging this one now.

aliok commented 4 months ago

/lgtm /approve

knative-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, Leo6Leo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/backstage-plugins/blob/main/OWNERS)~~ [Leo6Leo,aliok] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Leo6Leo commented 3 months ago

/unhold

aliok commented 3 months ago

@Leo6Leo were you able to verify on Slack that this works?