search

knative-extensions / backstage-plugins

Knative plugins for Backstage.
Apache License 2.0
3 stars 18 forks source link

Run TS compile before tests #77

Closed aliok closed 3 months ago

aliok commented 3 months ago

Fixes #45

Changes

/kind

Fixes #

Release Note

Docs

knative-prow[bot] commented 3 months ago

@aliok: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/knative-extensions/backstage-plugins/pull/77): >Fixes #45 > > > > > ># Changes > > > >- Run TS compile before tests, so that we make sure that the compilation errors in tests are not ignored >- >- > > >/kind > > >Fixes # > > > >**Release Note** > > >```release-note > >``` > >**Docs** > > >```docs > >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
aliok commented 3 months ago

cc @pierDipi

knative-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/backstage-plugins/blob/main/OWNERS)~~ [aliok,pierDipi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment