search

knative-extensions / backstage-plugins

Knative plugins for Backstage.
Apache License 2.0
3 stars 19 forks source link

Run NPM package tests before publishing Golang code #78

Closed aliok closed 2 months ago

aliok commented 3 months ago

Fixes #21

Changes

-

-

/kind

Fixes #

Release Note

Docs

knative-prow[bot] commented 3 months ago

@aliok: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/knative-extensions/backstage-plugins/pull/78): >Fixes #21 > > > > > ># Changes > > > >- >- >- > > >/kind > > >Fixes # > > > >**Release Note** > > >```release-note > >``` > >**Docs** > > >```docs > >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
aliok commented 3 months ago

Gonna reopen for testing Prow changes here: https://github.com/knative/infra/pull/507

aliok commented 3 months ago

/close

knative-prow[bot] commented 3 months ago

@aliok: Closed this PR.

In response to [this](https://github.com/knative-extensions/backstage-plugins/pull/78#issuecomment-2298513865): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
aliok commented 3 months ago

Depends on https://github.com/knative/infra/pull/508

aliok commented 2 months ago

/retest all

knative-prow[bot] commented 2 months ago

@aliok: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/knative-extensions/backstage-plugins/pull/78#issuecomment-2326313436): >/retest all Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
aliok commented 2 months ago

/test all

aliok commented 2 months ago

hmm, still using the old image. Gonna close and reopen

aliok commented 2 months ago

@pierDipi this is ready for review

aliok commented 2 months ago

@pierDipi good now?

aliok commented 2 months ago

I didn't remove the e2e tests sh file, as it is used in Prow setup. Currently empty though.

knative-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/backstage-plugins/blob/main/OWNERS)~~ [aliok,pierDipi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment