knative-extensions / backstage-plugins

Knative plugins for Backstage.

Apache License 2.0

3 stars 17 forks source link

Backend unit tests #8

Closed aliok closed 7 months ago

aliok commented 7 months ago

Changes

Backend unit tests
(Prow config will come later, but at least GH Action "Unit test" verifies the tests)

/kind

Fixes #

Release Note

Docs

knative-prow[bot] commented 7 months ago

@aliok: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/knative-extensions/backstage-plugins/pull/8): >**HOLD:** Builds on top of https://github.com/knative-extensions/backstage-plugins/pull/7 > > > > > ># Changes > > > >- Backend unit tests >- >- > > >/kind > > >Fixes # > > > >**Release Note** > > >```release-note > >``` > >**Docs** > > >```docs > >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

jarias-lfx commented 7 months ago

/easycla

aliok commented 7 months ago

cc @pierDipi @matzew

aliok commented 7 months ago

I changed the code so that it doesn't do any deduplication.

It will look like this: https://github.com/knative-extensions/backstage-plugins/pull/8#discussion_r1430110667

aliok commented 7 months ago

cc @matzew

aliok commented 7 months ago

We had a meeting with @matzew

Decisions:

Go ahead as is (no deduplication)
Try these for a better representation:
- Option A: EventType group (deduped) to be a component, eventType instance to be an API
- Option B: EventType group (deduped) to be shown as an API, but show a separate tab in eventType detail view (for the instances)
- Option C: Make use of other relations available on Backstage

knative-prow[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/backstage-plugins/blob/main/OWNERS)~~ [aliok,matzew] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment