knative-extensions / control-protocol

Control protocol to enable interaction between control plane and data plane without redeploy
Apache License 2.0
2 stars 26 forks source link

fix call to WaitUntilJobDone + update some dependencies #148

Closed nader-ziada closed 2 years ago

nader-ziada commented 2 years ago

Changes

/kind bug

codecov[bot] commented 2 years ago

Codecov Report

Merging #148 (77fe9dd) into main (f22e1be) will decrease coverage by 0.27%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
- Coverage   81.88%   81.60%   -0.28%     
==========================================
  Files          21       21              
  Lines         723      723              
==========================================
- Hits          592      590       -2     
- Misses         92       93       +1     
- Partials       39       40       +1     
Impacted Files Coverage Δ
pkg/network/base_connection.go 87.69% <0.00%> (-3.08%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f22e1be...77fe9dd. Read the comment docs.

carlisia commented 2 years ago

/lgtm /approve

knative-prow-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlisia, nader-ziada

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-sandbox/control-protocol/blob/main/OWNERS)~~ [carlisia] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment