search

knative-extensions / control-protocol

Control protocol to enable interaction between control plane and data plane without redeploy
Apache License 2.0
2 stars 26 forks source link

Adding code of conduct to reference knative/community's CoC #153

Closed rhuss closed 2 years ago

knative-prow-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-sandbox/control-protocol/blob/main/OWNERS)~~ [rhuss] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 2 years ago

Codecov Report

Merging #153 (84fb7ac) into main (6db44fb) will decrease coverage by 0.27%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
- Coverage   81.88%   81.60%   -0.28%     
==========================================
  Files          21       21              
  Lines         723      723              
==========================================
- Hits          592      590       -2     
- Misses         92       93       +1     
- Partials       39       40       +1
Impacted Files Coverage Δ
pkg/network/base_connection.go 87.69% <0.00%> (-3.08%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6db44fb...84fb7ac. Read the comment docs.

rhuss commented 2 years ago

@knative-sandbox/eventing-writers can please someone lgtm this PR ? Thanks !

nader-ziada commented 2 years ago

/lgtm