knative-extensions / control-protocol

Control protocol to enable interaction between control plane and data plane without redeploy
Apache License 2.0
2 stars 26 forks source link

Updated top level README to indicate usage in distributed KafkaChannel #156

Closed travis-minke-sap closed 2 years ago

travis-minke-sap commented 2 years ago

Changes

/kind enhancement

Fixes #154

Frequently the added maintenance of this repo results into questions of usage in the hopes that it can be removed.

knative-prow-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: travis-minke-sap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-sandbox/control-protocol/blob/main/OWNERS)~~ [travis-minke-sap] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 2 years ago

Codecov Report

Merging #156 (7160cbb) into main (b92711b) will increase coverage by 0.27%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
+ Coverage   81.60%   81.88%   +0.27%     
==========================================
  Files          21       21              
  Lines         723      723              
==========================================
+ Hits          590      592       +2     
+ Misses         93       92       -1     
+ Partials       40       39       -1     
Impacted Files Coverage Ξ”
pkg/network/base_connection.go 90.76% <0.00%> (+3.07%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update b92711b...7160cbb. Read the comment docs.

eric-sap commented 2 years ago

/lgtm