Closed knative-automation closed 2 years ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: knative-automation
To complete the pull request process, please assign travis-minke-sap after the PR has been reviewed.
You can assign the PR to them by writing /assign @travis-minke-sap
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Merging #162 (070ba00) into main (5a6a695) will increase coverage by
1.05%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #162 +/- ##
==========================================
+ Coverage 81.60% 82.66% +1.05%
==========================================
Files 21 21
Lines 723 1090 +367
==========================================
+ Hits 590 901 +311
- Misses 93 148 +55
- Partials 40 41 +1
Impacted Files | Coverage Δ | |
---|---|---|
pkg/service/service_caching_wrapper.go | 87.50% <0.00%> (-1.39%) |
:arrow_down: |
pkg/network/base_connection.go | 86.60% <0.00%> (-1.09%) |
:arrow_down: |
pkg/message/async_command_result.go | 89.65% <0.00%> (-0.83%) |
:arrow_down: |
pkg/service/service.go | 81.73% <0.00%> (-0.62%) |
:arrow_down: |
pkg/reconciler/tls_dialer_factory.go | 85.36% <0.00%> (-0.35%) |
:arrow_down: |
pkg/network/tls.go | 0.00% <0.00%> (ø) |
|
pkg/message/async_command.go | 100.00% <0.00%> (ø) |
|
pkg/network/message_queue.go | 100.00% <0.00%> (ø) |
|
pkg/service/message_router.go | 100.00% <0.00%> (ø) |
|
pkg/reconciler/connection_pool_option.go | 100.00% <0.00%> (ø) |
|
... and 10 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f12d619...070ba00. Read the comment docs.
redo -dprotaso
/cc knative-sandbox/eventing-writers /assign knative-sandbox/eventing-writers
Produced by: knative-sandbox/knobots/actions/update-community
Details: