search

knative-extensions / control-protocol

Control protocol to enable interaction between control plane and data plane without redeploy
Apache License 2.0
2 stars 26 forks source link

:broom: Accommodate to knative-sandbox/reconciler-test#294 #197

Closed cardil closed 2 years ago

cardil commented 2 years ago

Changes

codecov[bot] commented 2 years ago

Codecov Report

Merging #197 (7c34563) into main (4dcc992) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #197   +/-   ##
=======================================
  Coverage   82.93%   82.93%           
=======================================
  Files          21       21           
  Lines        1090     1090           
=======================================
  Hits          904      904           
  Misses        146      146           
  Partials       40       40

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

cardil commented 2 years ago

/retest

cardil commented 2 years ago

Please, review

/cc @knative-sandbox/eventing-writers /cc @knative-sandbox/control-protocol-approvers

/cc @odacremolbap /cc @aliok /cc @matzew /cc @lionelvillard /cc @eric-sap /cc @travis-minke-sap

dprotaso commented 2 years ago

looks like this needs a rebase

I made the manifest.InstallYamlFS changes

cardil commented 2 years ago

@dprotaso please take a look again

dprotaso commented 2 years ago

looks like there's a panic with the e2e stuff

cardil commented 2 years ago

Yea. I've also noticed that.

/hold

cardil commented 2 years ago

/unhold

Fixed.

@dprotaso Please take a look. With f7f6e07433cb75b8640643edf37488f2284e5077, I've migrated the way to handle test images to the reconciler-test way of things.

dprotaso commented 2 years ago

/lgtm /approve /hold for nit

feel free to unhold

knative-prow[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-sandbox/control-protocol/blob/main/OWNERS)~~ [dprotaso] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dprotaso commented 2 years ago

/hold cancel

we should fix how ko is invoked - but it shouldn't block this PR