knative-extensions / control-protocol

Control protocol to enable interaction between control plane and data plane without redeploy
Apache License 2.0
2 stars 26 forks source link

bump k8s versions used by e2e #227

Closed nader-ziada closed 1 year ago

nader-ziada commented 1 year ago

Changes

codecov[bot] commented 1 year ago

Codecov Report

Merging #227 (5d42e48) into main (ed5e550) will increase coverage by 0.36%. The diff coverage is n/a.

:exclamation: Current head 5d42e48 differs from pull request most recent head 587c7ef. Consider uploading reports for the commit 587c7ef to get more accurate results

@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
+ Coverage   72.89%   73.26%   +0.36%     
==========================================
  Files          23       23              
  Lines        1380     1380              
==========================================
+ Hits         1006     1011       +5     
+ Misses        317      313       -4     
+ Partials       57       56       -1     
Impacted Files Coverage Δ
pkg/network/base_connection.go 91.96% <0.00%> (+2.67%) :arrow_up:
pkg/network/client_connection.go 91.89% <0.00%> (+2.70%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

nader-ziada commented 1 year ago

/retest

dprotaso commented 1 year ago

/lgtm /approve

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, nader-ziada

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-sandbox/control-protocol/blob/main/OWNERS)~~ [dprotaso] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
nader-ziada commented 1 year ago

/retest