knative-extensions / control-protocol

Control protocol to enable interaction between control plane and data plane without redeploy
Apache License 2.0
2 stars 26 forks source link

Go mod update from 2-3 days ago that seemed to pass tests #243

Closed evankanderson closed 1 year ago

evankanderson commented 1 year ago

Changes

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-sandbox/control-protocol/blob/main/OWNERS)~~ [evankanderson] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 1 year ago

Codecov Report

Merging #243 (35361d0) into main (78c2c81) will increase coverage by 0.21%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
+ Coverage   73.04%   73.26%   +0.21%     
==========================================
  Files          23       23              
  Lines        1380     1380              
==========================================
+ Hits         1008     1011       +3     
+ Misses        315      313       -2     
+ Partials       57       56       -1     
Impacted Files Coverage Δ
pkg/network/base_connection.go 91.96% <0.00%> (+2.67%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

evankanderson commented 1 year ago

/assign @psschwei

Bisecting on #240 ... if we merge this, we get to 2-3 days before the release cut.

evankanderson commented 1 year ago

/close

knative-prow[bot] commented 1 year ago

@evankanderson: Closed this PR.

In response to [this](https://github.com/knative-sandbox/control-protocol/pull/243#issuecomment-1387457811): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
knative-prow-robot commented 1 year ago

@evankanderson: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.