Closed evankanderson closed 1 year ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: evankanderson
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Merging #243 (35361d0) into main (78c2c81) will increase coverage by
0.21%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #243 +/- ##
==========================================
+ Coverage 73.04% 73.26% +0.21%
==========================================
Files 23 23
Lines 1380 1380
==========================================
+ Hits 1008 1011 +3
+ Misses 315 313 -2
+ Partials 57 56 -1
Impacted Files | Coverage Δ | |
---|---|---|
pkg/network/base_connection.go | 91.96% <0.00%> (+2.67%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
/assign @psschwei
Bisecting on #240 ... if we merge this, we get to 2-3 days before the release cut.
/close
@evankanderson: Closed this PR.
@evankanderson: PR needs rebase.
Changes
update-deps.sh
with https://github.com/knative-sandbox/control-protocol/commit/14f9acf74d5b45661a5f06b4302d4134fb302be6 as a basis