knative-extensions / control-protocol

Control protocol to enable interaction between control plane and data plane without redeploy
Apache License 2.0
2 stars 26 forks source link

Fix Conformance test due to parallel phases #246

Closed pierDipi closed 1 year ago

pierDipi commented 1 year ago

Wait for server ready in the same step where it is created.

Another approach is to make WaitForPodRunningOrFail more resilient by considering NotFound as "not running"

Changes

/kind bug

Fixes #

knative-prow[bot] commented 1 year ago

@pierDipi: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/knative-sandbox/control-protocol/pull/246): > > ># Changes > > > >- >- >- > > >/kind > > >Fixes # > > > >**Release Note** > > >```release-note > >``` > >**Docs** > > >```docs > >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
codecov[bot] commented 1 year ago

Codecov Report

Merging #246 (28a66ba) into main (78c2c81) will decrease coverage by 0.15%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
- Coverage   73.04%   72.89%   -0.15%     
==========================================
  Files          23       23              
  Lines        1380     1380              
==========================================
- Hits         1008     1006       -2     
- Misses        315      317       +2     
  Partials       57       57              
Impacted Files Coverage Δ
pkg/network/client_connection.go 89.18% <0.00%> (-2.71%) :arrow_down:
pkg/network/base_connection.go 89.28% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

pierDipi commented 1 year ago

/cc @evankanderson

evankanderson commented 1 year ago

/lgtm /approve

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-sandbox/control-protocol/blob/main/OWNERS)~~ [evankanderson,pierDipi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment