Closed knative-prow-robot closed 1 year ago
/lgtm /approve
Merging #253 (60eaa63) into release-1.8 (3e2f878) will decrease coverage by
9.83%
. The diff coverage is35.39%
.
@@ Coverage Diff @@
## release-1.8 #253 +/- ##
===============================================
- Coverage 82.66% 72.83% -9.83%
===============================================
Files 21 23 +2
Lines 1090 1377 +287
===============================================
+ Hits 901 1003 +102
- Misses 148 317 +169
- Partials 41 57 +16
Impacted Files | Coverage Δ | |
---|---|---|
pkg/certificates/reconciler/reconciler.go | 27.96% <27.96%> (ø) |
|
pkg/certificates/reconciler/controller_impl.go | 62.50% <62.50%> (ø) |
|
pkg/certificates/reconciler/controller.go | 92.85% <100.00%> (+0.54%) |
:arrow_up: |
pkg/network/base_connection.go | 89.28% <0.00%> (+2.67%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: evankanderson, knative-prow-robot
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Based on report here: https://cloud-native.slack.com/archives/C04LMU0AX60/p1674692609842299
I think the code coverage is broken for this branch unsure why
/override codecov/patch /override codecov/project
@dprotaso: Overrode contexts on behalf of dprotaso: codecov/patch, codecov/project
This is an automated cherry-pick of #225