Add FakeDnsName

[davidhadas]

https://github.com/knative-sandbox/control-protocol/pull/265 Was intended to allow gradual change.

The change of FakeDnsName to LegacyFakeDnsName broke dependencies which was not intentional. The CreateControlPlaneCert, CreateDataPlaneCert also break dependencies as the prior behavior expected that FakeDnsName san be added by default.

This is a fix to ensure dependencies are not broken - we will gradually next need to identify dependencies and change them to use:

• LegacyFakeDnsName instead of FakeDnsName
• CreateCert instead of CreateControlPlaneCert, CreateDataPlaneCert

[codecov[bot]]

Codecov Report

Merging #269 (abad3bf) into main (e5eadf2) will decrease coverage by 0.08%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #269      +/-   ##
==========================================
- Coverage   73.11%   73.04%   -0.08%     
==========================================
  Files          23       23              
  Lines        1380     1380              
==========================================
- Hits         1009     1008       -1     
  Misses        315      315              
- Partials       56       57       +1     

Impacted Files	Coverage Δ
pkg/network/tls.go	0.00% <0.00%> (ø)
pkg/certificates/reconciler/certificates.go	69.52% <100.00%> (ø)
pkg/reconciler/tls_dialer_factory.go	85.36% <100.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[dprotaso]

/lgtm /approve

[knative-prow[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidhadas, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-sandbox/control-protocol/blob/main/OWNERS)~~ [dprotaso] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment