search

knative-extensions / control-protocol

Control protocol to enable interaction between control plane and data plane without redeploy
Apache License 2.0
2 stars 26 forks source link

Increase rotationThreshold to 24 hours #273

Closed nak3 closed 1 year ago

nak3 commented 1 year ago

As per title, this patch increase rotationThreshold to 24 hours.

As described in https://github.com/knative-sandbox/control-protocol/issues/272, the rotation does not happen when secret is not updated. The DefaultResyncPeriod is 10hour so increasing 24 hours should work.

pkg/webhook also has the 24 hours threshold.

Fix https://github.com/knative-sandbox/control-protocol/issues/272

codecov[bot] commented 1 year ago

Codecov Report

Merging #273 (83de97e) into main (3531529) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #273   +/-   ##
=======================================
  Coverage   73.17%   73.17%           
=======================================
  Files          23       23           
  Lines        1394     1394           
=======================================
  Hits         1020     1020           
  Misses        317      317           
  Partials       57       57
Impacted Files Coverage Δ
pkg/certificates/reconciler/certificates.go 69.49% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

nak3 commented 1 year ago

/cc @davidhadas @evankanderson @ReToCode

davidhadas commented 1 year ago

This change means we will replace any certificate that has less than 24 H to expire. Our certificates are created for 30 days, so replacing them after 29 days makes sense. /lgtm

evankanderson commented 1 year ago

/approve

We should get some of y'all into owners for this repo.

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidhadas, evankanderson, nak3, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-sandbox/control-protocol/blob/main/OWNERS)~~ [evankanderson] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
davidhadas commented 1 year ago

/unhold