knative-extensions / control-protocol

Control protocol to enable interaction between control plane and data plane without redeploy
Apache License 2.0
2 stars 26 forks source link

Invalidate certificate with wrong ca #285

Closed davidhadas closed 1 year ago

davidhadas commented 1 year ago

Fixes #274

davidhadas commented 1 year ago

/cc @nak3 @ReToCode

codecov[bot] commented 1 year ago

Codecov Report

Merging #285 (234692e) into main (4c3c81d) will decrease coverage by 0.36%. The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main     #285      +/-   ##
==========================================
- Coverage   73.17%   72.81%   -0.36%     
==========================================
  Files          23       23              
  Lines        1394     1398       +4     
==========================================
- Hits         1020     1018       -2     
- Misses        317      321       +4     
- Partials       57       59       +2     
Impacted Files Coverage Δ
pkg/certificates/reconciler/certificates.go 68.03% <88.88%> (-1.46%) :arrow_down:

... and 1 file with indirect coverage changes

nak3 commented 1 year ago

/lgtm

Thank you!

nak3 commented 1 year ago

/approve

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidhadas, matzew, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-sandbox/control-protocol/blob/main/OWNERS)~~ [matzew] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment