knative-extensions / eventing-autoscaler-keda

KEDA support for Knative Event Sources Autoscaling
Apache License 2.0
46 stars 37 forks source link

Refactor to depend on eventing-kafka-broker only, drop eventing-kafka #482

Closed dsimansk closed 7 months ago

dsimansk commented 7 months ago

Changes

This refactor drops eventing-kafka in favor of eventing-kafka-broker. The eventing-kafka won't have any new release, therefore we won't be able to satisfy releasability check and overall maintenance of this component.

/cc @creydr @Cali0707 @pierDipi

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (bf5740a) to head (0cceb6e). Report is 12 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #482 +/- ## ====================================== Coverage 0.00% 0.00% ====================================== Files 15 15 Lines 984 757 -227 ====================================== + Misses 984 757 -227 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

knative-prow[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/eventing-autoscaler-keda/blob/main/OWNERS)~~ [dsimansk,pierDipi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dsimansk commented 7 months ago

@pierDipi OK to unhold?

dsimansk commented 7 months ago

/unhold