knative-extensions / eventing-github

Github integration with Knative Eventing.
Apache License 2.0
20 stars 36 forks source link

'ceOverrides' field in CR does not seems to work in eventing-github adapter #448

Closed inspirit941 closed 6 months ago

inspirit941 commented 10 months ago

Describe the bug if I Set CeOverrides options in GithubSource CR and get event from github, CeOverrides extensions fields are not included in incoming cloudevent payload.

it seems like adding ceoverride extension logic is not exist in githubsource event adapter.

ceOverride field provided in GithubSource CR should be included in cloudevent.

To Reproduce

Knative release version tested in knative serving 1.11, knative eventing 1.11.2

Additional context

github-actions[bot] commented 7 months ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.