knative-extensions / eventing-integrations

Eventing integration container images
Apache License 2.0
0 stars 4 forks source link

S3: adding required setting to properties file #13

Closed matzew closed 1 week ago

matzew commented 1 week ago

With out this fix, I am getting:

s3-sink-deployment-7886f69cc-khspt sink Caused by: java.lang.IllegalArgumentException: Route template aws-s3-sink the following mandatory parameters must be provided: bucketNameOrArn, region
s3-sink-deployment-7886f69cc-khspt sink     at org.apache.camel.impl.DefaultModel.addRouteFromTemplate(DefaultModel.java:477)
s3-sink-deployment-7886f69cc-khspt sink     at org.apache.camel.impl.DefaultModel.addRouteFromTemplate(DefaultModel.java:416)
s3-sink-deployment-7886f69cc-khspt sink     at org.apache.camel.impl.DefaultCamelContext.addRouteFromTemplate(DefaultCamelContext.java:362)
s3-sink-deployment-7886f69cc-khspt sink     at org.apache.camel.component.kamelet.KameletComponent$LifecycleHandler.createRouteForEndpoint(KameletComponent.java:433)
s3-sink-deployment-7886f69cc-khspt sink     ... 28 more
s3-sink-deployment-7886f69cc-khspt sink 
matzew commented 1 week ago

@christophd can we perhaps update the archetype to also set this to empty (e.g. all required)?

At least temporary, until we know why this is needed?

knative-prow[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christophd, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/eventing-integrations/blob/main/OWNERS)~~ [matzew] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment