search

knative-extensions / eventing-kafka-broker

Alternate Kafka Broker implementation.
Apache License 2.0
169 stars 116 forks source link

New Event Filtering: Benchmark Java implementation of Base SubscriptionsAPI filters #3234

Closed Cali0707 closed 11 months ago

Cali0707 commented 1 year ago

Problem After #3233, we should add benchmarks for all of the base SubscriptionsAPI filters.

To add a benchmark for a new type of filter, add a file to this folder for the filter type, and then follow the pattern in https://github.com/knative-extensions/eventing-kafka-broker/pull/3247/files#diff-b300a22e800560bd785d1c686237dbd3bc39979e85ef6699adbbbec58e2101ca. Specifically, when making a new benchmark, you need to extend the FilterBenchmark class and override the createEvent and createFilter functions to create the desired event and filter to benchmark.

Exit Criteria Working benchmarks for each of:

Time Estimate (optional): How many developer-days do you think this may take to resolve? 1

Additional context (optional)

Cali0707 commented 1 year ago

/area data-plane /area test

Cali0707 commented 1 year ago

/triage accepted

Cali0707 commented 1 year ago

/good-first-issue

knative-prow[bot] commented 1 year ago

@Cali0707: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/knative-extensions/eventing-kafka-broker/issues/3234): >/good-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Cali0707 commented 1 year ago

/assign