search

knative-extensions / eventing-kafka-broker

Alternate Kafka Broker implementation.
Apache License 2.0
167 stars 111 forks source link

Spotless is not verified on PRs #3349

Open Cali0707 opened 10 months ago

Cali0707 commented 10 months ago

Describe the bug It seems like the code is not being verified to match the formatting provided by Spotless on PRs, as subsequent PRs are reformatting the code when ./hack/update-codegen.sh is run.

Expected behavior If code is not formatted properly, some CI job fails and indicates that the code should be formatted.

To Reproduce Create a PR with Java code and don't run the Spotless format command.

Knative release version

Additional context Add any other context about the problem here such as proposed priority

Cali0707 commented 10 months ago

/cc @Leo6Leo

github-actions[bot] commented 7 months ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

Cali0707 commented 7 months ago

/remove-lifecycle stale /cc @Leo6Leo

github-actions[bot] commented 4 months ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

Leo6Leo commented 4 months ago

/remove-lifecycle stale

github-actions[bot] commented 1 month ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

Cali0707 commented 3 weeks ago

/remove-lifecycle stale /triage accepted @Leo6Leo could you add a bit more info about the spotless stuff and then mark it either help wanted or good first issue? I'd do it myself but I really don't know much about the spotless setup we have

Leo6Leo commented 3 weeks ago

To add more details on this issue.

Spotless support is added to the knative-extensions eventing-kafka-broker repository in this PR. https://github.com/knative-extensions/eventing-kafka-broker/pull/3171

Problem: Spotless formatting is not checked during the CI process. Unformatted code can be merged without any CI checks failing.

Goal: Verify the code formatting in the CI.

Some more context:

/good-first-issue /help-wanted

knative-prow[bot] commented 3 weeks ago

@Leo6Leo: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/knative-extensions/eventing-kafka-broker/issues/3349): >To add more details on this issue. > >Spotless support is added to the knative-extensions eventing-kafka-broker repository in this PR. https://github.com/knative-extensions/eventing-kafka-broker/pull/3171 > >Problem: Spotless formatting is not checked during the CI process. Unformatted code can be merged without any CI checks failing. > >Goal: Verify the code formatting in the CI. > >Some more context: >- https://github.com/knative-extensions/eventing-kafka-broker/pull/3171#issuecomment-1620349258 >- https://github.com/knative-extensions/eventing-kafka-broker/pull/3171#issuecomment-1614256879 > >/good-first-issue >/help-wanted > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.