search

knative-extensions / eventing-kafka-broker

Alternate Kafka Broker implementation.
Apache License 2.0
168 stars 115 forks source link

Configure Trigger Scaling with KEDA through annotations #3811

Closed Cali0707 closed 1 month ago

Cali0707 commented 5 months ago

Problem Currently, users can configure KEDA scaling options through annotations when creating a KafkaSource. We should support the same set of annotations on triggers.

Persona: Which persona is this feature for?

Exit Criteria Scaling for triggers can be configured through annotations with the same API as KafkaSources

Time Estimate (optional): How many developer-days do you think this may take to resolve? 1-2

Additional context (optional) Add any other context about the feature request here.

Cali0707 commented 5 months ago

@pierDipi what do you think of allowing users to also set the annotations on the broker? I could see this maybe being easier, rather than needing to set it on each trigger. This would be the following behaviour then:

  1. If there is an annotation on the trigger, use those values
  2. If there is no annotation on the trigger, but there is an annotation on the broker, use the broker annotation
  3. Otherwise, use the default values
Cali0707 commented 5 months ago

Also @pierDipi - regarding out discussion about how to set the scale on the trigger manually, what about: if the autoscaling class is set to disabled, then we will use the AutoscalingMinScale annotation?

github-actions[bot] commented 2 months ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.