search

knative-extensions / eventing-kafka-broker

Alternate Kafka Broker implementation.
Apache License 2.0
185 stars 117 forks source link

Fix lint errors #4008

Open pierDipi opened 3 months ago

pierDipi commented 3 months ago

Describe the bug

There are a few lint errors we need to fix https://github.com/knative-extensions/eventing-kafka-broker/actions/runs/10079854577/job/27868194009?pr=4005

Expected behavior

No lint errors

To Reproduce

Run lint GH action

Knative release version main

Additional context

/good-first-issue

knative-prow[bot] commented 3 months ago

@pierDipi: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/knative-extensions/eventing-kafka-broker/issues/4008): > > >**Describe the bug** > >There are a few lint errors we need to fix https://github.com/knative-extensions/eventing-kafka-broker/actions/runs/10079854577/job/27868194009?pr=4005 > > **Expected behavior** > >No lint errors > > **To Reproduce** > >Run lint GH action > > **Knative release version** >`main` > > **Additional context** > >/good-first-issue > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
rissh commented 3 months ago

Hey @pierDipi ,

I'm planning to work on this issue. Can you please assign me this issue? Please feel free to provide any suggestions or guidance as I work on this task. I'm open to feedback and would appreciate any insights you might have.

Thank you!

ukane-philemon commented 3 months ago

'm planning to work on this issue. Can you please assign me this issue?

No one has signified interest before now, you can get the fix ready, PR and cite this issue so @pierDipi can just review the real thing.

pierDipi commented 3 months ago

Thanks @rissh, to get the issue assigned to you, you can comment with /assign and the bot will assign the issue to you.

Feel free to ask any questions you have directly here

rahulii commented 3 months ago

/assign

github-actions[bot] commented 2 weeks ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.