[control-plane] List applying policies in KafkaChannels `.status.policies`

creydr commented 1 month ago

As the Eventing Authorization feature track describes, target resources of EventPolicies, will reflect in their status, which EventPolicy is applied to them.

For example:

apiVersion: kafkachannels.messaging.knative.dev/v1
kind: KafkaChannel
metadata:
  name: my-channel
spec:
  ...
status:
  ...
  policies:
    - name: event-policy
      apiVersion: v1alpha1
    - name: another-event-policy
      apiVersion: v1alpha1

  conditions:
    - type: Ready
      status: "True"
    - type: EventPoliciesReady
      status: "True"

As the KafkaChannel should support EventPolicies, wee need to do the following:

Update the KafkaChannel reconciler to show applying policies in the KafkaChannels .status.policies and set the KafkaChannels EventPoliciesReady condition. Also watch EventPolicies for changes.
Set EventPoliciesReady condition to true, in case no policy applies, and set message according to the default-authorization-mode (e.g. Default authorization mode is 'allow-all'). Check the Default Authorization Mode section in the feature track for additional information.

Hint:

Similar to https://github.com/knative/eventing/issues/7977
Requires #4069

Additional hints for new contributors before starting with this issue:

When the issue has the Draft status, the issue is subject to change and thus should not be started to be worked on
Make sure you've read and understood the CONTRIBUTING.md guidelines
Make sure you're able to run Knative Eventing locally with Knative Eventing Kafka and run at least the unit tests.
Feel free to raise any questions you have either directly here in the issue, in the #knative-eventing Slack channel or join the Eventing Workgroup Meeting / Office Hours
When you feel comfortable with this issue, feel free to assign it to you (e.g. by commenting /assign). Please be aware that we might unassign you, if we don't see any progress from your side to give other contributors also a chance to work on this issue.

creydr commented 1 month ago

/help /triage accepted

knative-prow[bot] commented 1 month ago

@creydr: This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to [this](https://github.com/knative-extensions/eventing-kafka-broker/issues/4038): >/help >/triage accepted Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

Cali0707 commented 1 month ago

/area control-plane

rahulii commented 1 month ago

/assign

creydr commented 4 weeks ago

@rahulii when #4063 is merged, this should be ready to be worked on

creydr commented 3 weeks ago

@rahulii as #4063 merged, this is ready to be worked on. Let me know in case you have any questions

rahulii commented 3 weeks ago

Thanks @creydr , will start on this.

creydr commented 2 weeks ago

Hey @rahulii, did you have a chance to work on this?

rahulii commented 2 weeks ago

hey @creydr will raise a PR by tomorrow max. Appologies for the delay!

knative-extensions / eventing-kafka-broker

[control-plane] List applying policies in KafkaChannels `.status.policies` #4038