knative-extensions / eventing-kafka-broker

Alternate Kafka Broker implementation.
Apache License 2.0
167 stars 111 forks source link

Unable to deploy Kafka Sink data plane with v0.21.0 #712

Closed goldmann closed 3 years ago

goldmann commented 3 years ago

Describe the bug After following the documentation at: https://knative.dev/docs/eventing/sink/kafka-sink/ I couldn't get a sink created. The reason for it is that the ServiceAccount, ClusterRole and ClusterRoleBinding resources are missing in the https://github.com/knative-sandbox/eventing-kafka-broker/releases/tag/v0.21.0

Once I fixed this manually by applying files 200* from here: https://github.com/knative-sandbox/eventing-kafka-broker/tree/main/data-plane/config I was able to run the sink.

Expected behavior Sink should be deployed.

To Reproduce Follow instructions at https://github.com/knative-sandbox/eventing-kafka-broker/releases/tag/v0.21.0 :)

Knative release version v0.21.0

Additional context None.

pierDipi commented 3 years ago

Thanks for reporting!

/assign

lionelvillard commented 3 years ago

I have the same issue

message: 'pods "kafka-sink-receiver-868cffcdc7-" is forbidden: error looking up
      service account knative-eventing/knative-kafka-data-plane: serviceaccount "knative-kafka-data-plane"
      not found'
pierDipi commented 3 years ago

There is a PR to fix it, sorry about that! https://github.com/knative-sandbox/eventing-kafka-broker/pull/714

pierDipi commented 3 years ago

The following are the missing artifacts:

---
# Copyright 2020 The Knative Authors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
apiVersion: v1
kind: ConfigMap
metadata:
  name: kafka-config-logging
  namespace: knative-eventing
  labels:
    kafka.eventing.knative.dev/release: devel
data:
  config.xml: |
    <configuration>
      <appender name="jsonConsoleAppender" class="ch.qos.logback.core.ConsoleAppender">
        <encoder class="net.logstash.logback.encoder.LogstashEncoder"/>
      </appender>
      <root level="INFO">
        <appender-ref ref="jsonConsoleAppender"/>
      </root>
    </configuration>

---
# Copyright 2020 The Knative Authors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  name: knative-kafka-data-plane
  labels:
    kafka.eventing.knative.dev/release: devel
rules:
  - apiGroups:
      - "*"
    resources:
      - secrets
    verbs:
      - get

---
# Copyright 2020 The Knative Authors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
apiVersion: v1
kind: ServiceAccount
metadata:
  name: knative-kafka-data-plane
  namespace: knative-eventing
  labels:
    kafka.eventing.knative.dev/release: devel

---
# Copyright 2020 The Knative Authors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
  name: knative-kafka-data-plane
  labels:
    kafka.eventing.knative.dev/release: devel
subjects:
  - kind: ServiceAccount
    name: knative-kafka-data-plane
    namespace: knative-eventing
roleRef:
  kind: ClusterRole
  name: knative-kafka-data-plane
  apiGroup: rbac.authorization.k8s.io

---