Change KafkaChannel defaults for partition and replica

knative-extensions / eventing-kafka

Kafka integrations with Knative Eventing.

Apache License 2.0

77 stars 82 forks source link

Change KafkaChannel defaults for partition and replica #1006

Open matzew opened 2 years ago

matzew commented 2 years ago

Problem The current defaults for setting partitions and replica to 1 is a pretty poor choice.

We noticed in tests that it is much much better if we default to something like 10 partitions and 3 replica

The issue here is that 3 replica does not work single broker instances, but those are generally considered being a toy.

For POCs or demos, the replica can be still configured to be 1, on the actual KafkaChannel object - so single broker usage is still possible

Persona: Which persona is this feature for?

Exit Criteria A measurable (binary) test that would indicate that the problem has been resolved.

Time Estimate (optional): How many developer-days do you think this may take to resolve?

Additional context (optional) Add any other context about the feature request here.

pierDipi commented 2 years ago

I can bring this in today's Kafka WG call if you won't join.

aliok commented 2 years ago

I don't have a strong opinion.

Defaults that are good for getting started: prod users should set the config
Defaults that are better for prod: getting-started-users should set the config

I think I would still prefer option 1, but I am ok with it both

travis-minke-sap commented 2 years ago

I'm ok either way ; ) (fwiw - we set them in all KafkaChannel instances for our production use cases)

matzew commented 2 years ago

FWIW, we have the same defaults on the knative kafka broker

pierDipi commented 2 years ago

/reopen

knative-prow-robot commented 2 years ago

@pierDipi: Reopened this issue.

In response to [this](https://github.com/knative-sandbox/eventing-kafka/issues/1006#issuecomment-1041864877): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

github-actions[bot] commented 2 years ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

pierDipi commented 2 years ago

/remove-lifecycle stale /triage accepted