search

knative-extensions / eventing-natss

NATS streaming integration with Knative Eventing.
Apache License 2.0
38 stars 39 forks source link

[main] Upgrade to latest dependencies #487

Closed knative-automation closed 5 months ago

knative-automation commented 5 months ago

Cron -knative-prow-robot

/cc knative-extensions/eventing-writers /assign knative-extensions/eventing-writers

Produced by: knative-extensions/knobots/actions/update-deps

knative-prow[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knative-automation Once this PR has been reviewed and has the lgtm label, please assign odacremolbap for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/knative-extensions/eventing-natss/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9e61795) 45.32% compared to head (ddf9af4) 45.32%.

:exclamation: Current head ddf9af4 differs from pull request most recent head c27f5a8. Consider uploading reports for the commit c27f5a8 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #487 +/- ## ======================================= Coverage 45.32% 45.32% ======================================= Files 30 30 Lines 1966 1966 ======================================= Hits 891 891 Misses 1020 1020 Partials 55 55 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Cali0707 commented 5 months ago

@creydr it looks like the 1.26.6 KinD tests are failing here, should we bump the job to 1.27 as that's the new min k8s version?

creydr commented 5 months ago

@creydr it looks like the 1.26.6 KinD tests are failing here, should we bump the job to 1.27 as that's the new min k8s version?

sounds good. Maybe we can update https://github.com/knative-extensions/eventing-natss/blob/a4d703860a577feccce37172b3360647c5508b00/.github/workflows/kind-e2e.yaml#L20-L21 too (in a separate PR)

Cali0707 commented 5 months ago

sounds good. Maybe we can update

https://github.com/knative-extensions/eventing-natss/blob/a4d703860a577feccce37172b3360647c5508b00/.github/workflows/kind-e2e.yaml#L20-L21 too (in a separate PR)

@creydr I opened #490 and #491

creydr commented 5 months ago

Closing in favor of https://github.com/knative-extensions/eventing-natss/pull/492