search

knative-extensions / eventing-natss

NATS streaming integration with Knative Eventing.
Apache License 2.0
38 stars 39 forks source link

Upgrade dependencies #492

Closed Cali0707 closed 5 months ago

Cali0707 commented 5 months ago

Fixes build issues in #487 , and cleans up a few references to deprecated sets.String

Cali0707 commented 5 months ago

/cc @creydr @pierDipi

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8475062) 45.32% compared to head (51064bc) 45.32%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #492 +/- ## ======================================= Coverage 45.32% 45.32% ======================================= Files 30 30 Lines 1966 1966 ======================================= Hits 891 891 Misses 1020 1020 Partials 55 55 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

creydr commented 5 months ago

/lgtm cancel

creydr commented 5 months ago

Not sure if the current failing e2e tests are related to. Can you rebase, as you had some other PRs with updates there?

Cali0707 commented 5 months ago

/cc @creydr

knative-prow[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/eventing-natss/blob/main/OWNERS)~~ [Cali0707,creydr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment