search

knative-extensions / eventing-natss

NATS streaming integration with Knative Eventing.
Apache License 2.0
38 stars 39 forks source link

backported pkg files from release-1.10 #496

Closed astelmashenko closed 2 months ago

astelmashenko commented 5 months ago

Fixes #489

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 70.34884% with 51 lines in your changes are missing coverage. Please review.

Project coverage is 42.87%. Comparing base (b6a5e67) to head (5b77983). Report is 41 commits behind head on main.

Files Patch % Lines
...channel/jetstream/dispatcher/message_dispatcher.go 71.55% 23 Missing and 10 partials :warning:
pkg/channel/jetstream/dispatcher/consumer.go 0.00% 14 Missing :warning:
pkg/channel/jetstream/utils/consumerconfig.go 85.71% 2 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #496 +/- ## ========================================== - Coverage 45.32% 42.87% -2.45% ========================================== Files 30 61 +31 Lines 1966 2680 +714 ========================================== + Hits 891 1149 +258 - Misses 1020 1453 +433 - Partials 55 78 +23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

astelmashenko commented 5 months ago

/assign @dan-j

dan-j commented 2 months ago

/lgtm /approve

There is a small bug in both versions, but not going to stop merging this.. created a new issue #541 to track that

knative-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astelmashenko, dan-j

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/eventing-natss/blob/main/OWNERS)~~ [astelmashenko,dan-j] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dan-j commented 2 months ago

@astelmashenko Looks like one of the checks are failing on codecov: https://github.com/knative-extensions/eventing-natss/pull/496/checks?check_run_id=23785523290

astelmashenko commented 2 months ago

@astelmashenko Looks like one of the checks are failing on codecov: https://github.com/knative-extensions/eventing-natss/pull/496/checks?check_run_id=23785523290

Yeah, I'll take a look at it.

knative-prow[bot] commented 2 months ago

New changes are detected. LGTM label has been removed.

astelmashenko commented 2 months ago

Please check https://github.com/knative-extensions/eventing-natss/pull/545