Closed astelmashenko closed 5 months ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: astelmashenko
The full list of commands accepted by this bot can be found here.
The pull request process is described here
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 44.88%. Comparing base (
44752ad
) to head (60c36ab
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@Cali0707 , I need help with this PR, in some reason codecov calculates coverage deffirently, if I revert my changes and add additional tests it says there is less coverate anyway. Coverage according to test if I run it locally is 85.1% on codecov I see 79.78% Could you please help review and merge this PR, it fixes real issue started as discussion in slack.
@pierDipi , there is something with tests coverage, it is not the same if I run tests locally, it lost 6% coverage and I can not merge this PR. Could you please help skip the check?
/override codecov/project
@creydr: Overrode contexts on behalf of creydr: codecov/project
/cherry-pick main
@astelmashenko: #527 failed to apply on top of branch "main":
Applying: fixed case when no deliver configuration in subscription
Using index info to reconstruct a base tree...
A pkg/channel/jetstream/dispatcher/message_dispatcher.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): pkg/channel/jetstream/dispatcher/message_dispatcher.go deleted in HEAD and modified in fixed case when no deliver configuration in subscription. Version fixed case when no deliver configuration in subscription of pkg/channel/jetstream/dispatcher/message_dispatcher.go left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fixed case when no deliver configuration in subscription
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Fixes bug when subscription does not have delivery dispatcher goes into crashloop