knative-extensions / eventing-natss

NATS streaming integration with Knative Eventing.
Apache License 2.0
40 stars 41 forks source link

fixed case when no deliver configuration in subscription #527

Closed astelmashenko closed 5 months ago

astelmashenko commented 6 months ago

Fixes bug when subscription does not have delivery dispatcher goes into crashloop

knative-prow[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astelmashenko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/eventing-natss/blob/release-1.10/OWNERS)~~ [astelmashenko] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 44.88%. Comparing base (44752ad) to head (60c36ab).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-1.10 #527 +/- ## ================================================ - Coverage 51.06% 44.88% -6.19% ================================================ Files 30 60 +30 Lines 2197 3471 +1274 ================================================ + Hits 1122 1558 +436 - Misses 1001 1830 +829 - Partials 74 83 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

astelmashenko commented 6 months ago

@Cali0707 , I need help with this PR, in some reason codecov calculates coverage deffirently, if I revert my changes and add additional tests it says there is less coverate anyway. Coverage according to test if I run it locally is 85.1% on codecov I see 79.78% Could you please help review and merge this PR, it fixes real issue started as discussion in slack.

astelmashenko commented 6 months ago

@pierDipi , there is something with tests coverage, it is not the same if I run tests locally, it lost 6% coverage and I can not merge this PR. Could you please help skip the check?

creydr commented 5 months ago

/override codecov/project

knative-prow[bot] commented 5 months ago

@creydr: Overrode contexts on behalf of creydr: codecov/project

In response to [this](https://github.com/knative-extensions/eventing-natss/pull/527#issuecomment-2047536962): >/override codecov/project Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
astelmashenko commented 5 months ago

/cherry-pick main

knative-prow-robot commented 5 months ago

@astelmashenko: #527 failed to apply on top of branch "main":

Applying: fixed case when no deliver configuration in subscription
Using index info to reconstruct a base tree...
A   pkg/channel/jetstream/dispatcher/message_dispatcher.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): pkg/channel/jetstream/dispatcher/message_dispatcher.go deleted in HEAD and modified in fixed case when no deliver configuration in subscription. Version fixed case when no deliver configuration in subscription of pkg/channel/jetstream/dispatcher/message_dispatcher.go left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fixed case when no deliver configuration in subscription
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/knative-extensions/eventing-natss/pull/527#issuecomment-2047638065): >/cherry-pick main Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.