JetStream consumer does not properly propagate tracing context

knative-extensions / eventing-natss

NATS streaming integration with Knative Eventing.

Apache License 2.0

40 stars 41 forks source link

JetStream consumer does not properly propagate tracing context #541

Open dan-j opened 5 months ago

dan-j commented 5 months ago

Describe the bug

This bit of code attaches the trace to c.ctx and not ctx, then ctx is used in SendMessage()

https://github.com/knative-extensions/eventing-natss/blob/ab53a990254da0c58a72621b1a6b449d80ac19f3/pkg/channel/jetstream/dispatcher/consumer.go#L155-L177

github-actions[bot] commented 2 months ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

astelmashenko commented 2 months ago

/remove-lifecycle stale