search

knative-extensions / eventing-natss

NATS streaming integration with Knative Eventing.
Apache License 2.0
38 stars 39 forks source link

fix: add .spec.subscribers[].name field in NATSS channel to align with eventing core #550

Closed Cali0707 closed 2 months ago

Cali0707 commented 2 months ago

Similar to https://github.com/knative-extensions/eventing-kafka-broker/pull/3845

Proposed Changes

Cali0707 commented 2 months ago

/cc @Leo6Leo @creydr @astelmashenko

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.60%. Comparing base (4277051) to head (d5549fe). Report is 9 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #550 +/- ## ========================================== + Coverage 39.58% 39.60% +0.02% ========================================== Files 60 60 Lines 3178 2555 -623 ========================================== - Hits 1258 1012 -246 + Misses 1855 1478 -377 Partials 65 65 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Leo6Leo commented 2 months ago

/lgtm

astelmashenko commented 2 months ago

/lgtm

astelmashenko commented 2 months ago

/approve

knative-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astelmashenko, Cali0707

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/eventing-natss/blob/main/OWNERS)~~ [Cali0707,astelmashenko] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Cali0707 commented 2 months ago

/override "style / Golang" /override "style / suggester / github_actions" /override "style / suggester / yaml" /override "style / suggester / shell"

knative-prow[bot] commented 2 months ago

@Cali0707: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/knative-extensions/eventing-natss/pull/550#issuecomment-2072289436): >/override "style / Golang" >/override "style / suggester / github_actions" >/override "style / suggester / yaml" >/override "style / suggester / shell" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Cali0707 commented 2 months ago

/override "style / Golang" /override "style / suggester / github_actions" /override "style / suggester / shell"

knative-prow[bot] commented 2 months ago

@Cali0707: Overrode contexts on behalf of Cali0707: style / Golang, style / suggester / github_actions, style / suggester / shell

In response to [this](https://github.com/knative-extensions/eventing-natss/pull/550#issuecomment-2072293600): >/override "style / Golang" >/override "style / suggester / github_actions" >/override "style / suggester / shell" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.