search

knative-extensions / eventing-natss

NATS streaming integration with Knative Eventing.
Apache License 2.0
38 stars 39 forks source link

re-aplied PR 545 changes to release-1.14 #563

Closed astelmashenko closed 1 month ago

astelmashenko commented 1 month ago

This is a manual cherry-pick of https://github.com/knative-extensions/eventing-natss/pull/545

knative-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astelmashenko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/eventing-natss/blob/release-1.14/OWNERS)~~ [astelmashenko] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 70.34884% with 51 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (release-1.14@5e12e7f). Click here to learn what that means.

Files Patch % Lines
...channel/jetstream/dispatcher/message_dispatcher.go 71.55% 23 Missing and 10 partials :warning:
pkg/channel/jetstream/dispatcher/consumer.go 0.00% 14 Missing :warning:
pkg/channel/jetstream/utils/consumerconfig.go 85.71% 2 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-1.14 #563 +/- ## =============================================== Coverage ? 42.87% =============================================== Files ? 61 Lines ? 2680 Branches ? 0 =============================================== Hits ? 1149 Misses ? 1453 Partials ? 78 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.