search

knative-extensions / eventing-natss

NATS streaming integration with Knative Eventing.
Apache License 2.0
40 stars 42 forks source link

upgraded nats/jetstream libraries #583

Closed astelmashenko closed 4 months ago

astelmashenko commented 4 months ago

Upgraded nats/jetstream libraries to the latest version.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 43.57%. Comparing base (7626981) to head (1adaaf6).

Files Patch % Lines
pkg/channel/jetstream/controller/controller.go 0.00% 2 Missing :warning:
pkg/channel/jetstream/controller/reconciler.go 0.00% 1 Missing :warning:
pkg/channel/jetstream/dispatcher/controller.go 0.00% 1 Missing :warning:
pkg/channel/jetstream/dispatcher/dispatcher.go 0.00% 0 Missing and 1 partial :warning:
pkg/common/error/subscriber.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #583 +/- ## ========================================== + Coverage 42.87% 43.57% +0.70% ========================================== Files 61 61 Lines 2680 2678 -2 ========================================== + Hits 1149 1167 +18 + Misses 1453 1430 -23 - Partials 78 81 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

astelmashenko commented 4 months ago

/assign @Cali0707

knative-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astelmashenko, Cali0707

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/eventing-natss/blob/main/OWNERS)~~ [Cali0707,astelmashenko] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Cali0707 commented 4 months ago

/override "codecov/patch"

knative-prow[bot] commented 4 months ago

@Cali0707: Overrode contexts on behalf of Cali0707: codecov/patch

In response to [this](https://github.com/knative-extensions/eventing-natss/pull/583#issuecomment-2252884573): >/override "codecov/patch" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.