Closed ckyoog closed 5 months ago
Welcome @ckyoog! It looks like this is your first PR to knative-extensions/eventing-rabbitmq 🎉
/assign @ikavgo @Zerpet @mkuratczyk
hey @ckyoog thanks for the PR. You'll have to sign the CLA - can you follow the instructions by clicking on the red boxes in this comment - https://github.com/knative-extensions/eventing-rabbitmq/pull/1370#issuecomment-2038049250
Attention: Patch coverage is 33.33333%
with 8 lines
in your changes are missing coverage. Please review.
Project coverage is 64.66%. Comparing base (
9b15d3b
) to head (f292c47
). Report is 7 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
pkg/dispatcher/dispatcher.go | 11.11% | 8 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
closing and re-opening to refresh and get the latest github actions
@ckyoog please look here - https://github.com/knative-extensions/eventing-rabbitmq/pull/1370#issuecomment-2038049250 this email thingy prevents merge
Hi I was using a wrong email address in the commits. I just corrected them. I am wondering, if I used the right email address in the first place, would I still need to sign the CLA? Just curious.
/override "codecov/patch"
@ikavgo: ikavgo unauthorized: /override is restricted to Repo administrators.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ckyoog, ikavgo
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/override "codecov/patch"
@dprotaso: Overrode contexts on behalf of dprotaso: codecov/patch
It occurs when the rabbitmq server is down while the dispatcher is waiting for the response from the subscriber.
See #1369 for details.