knative-extensions / eventing-rabbitmq

RabbitMQ eventing components. Knative Source and Broker.
Apache License 2.0
90 stars 67 forks source link

Fix the deadlock in the dispatcher #1369 #1370

Closed ckyoog closed 5 months ago

ckyoog commented 5 months ago

It occurs when the rabbitmq server is down while the dispatcher is waiting for the response from the subscriber.

See #1369 for details.

linux-foundation-easycla[bot] commented 5 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

knative-prow[bot] commented 5 months ago

Welcome @ckyoog! It looks like this is your first PR to knative-extensions/eventing-rabbitmq 🎉

dprotaso commented 5 months ago

/assign @ikavgo @Zerpet @mkuratczyk

dprotaso commented 5 months ago

hey @ckyoog thanks for the PR. You'll have to sign the CLA - can you follow the instructions by clicking on the red boxes in this comment - https://github.com/knative-extensions/eventing-rabbitmq/pull/1370#issuecomment-2038049250

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 64.66%. Comparing base (9b15d3b) to head (f292c47). Report is 7 commits behind head on main.

Files Patch % Lines
pkg/dispatcher/dispatcher.go 11.11% 8 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1370 +/- ## ========================================== + Coverage 63.16% 64.66% +1.49% ========================================== Files 60 60 Lines 4333 3574 -759 ========================================== - Hits 2737 2311 -426 + Misses 1481 1148 -333 Partials 115 115 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dprotaso commented 5 months ago

closing and re-opening to refresh and get the latest github actions

ikavgo commented 5 months ago

@ckyoog please look here - https://github.com/knative-extensions/eventing-rabbitmq/pull/1370#issuecomment-2038049250 this email thingy prevents merge

ckyoog commented 5 months ago

Hi I was using a wrong email address in the commits. I just corrected them. I am wondering, if I used the right email address in the first place, would I still need to sign the CLA? Just curious.

ikavgo commented 5 months ago

/override "codecov/patch"

knative-prow[bot] commented 5 months ago

@ikavgo: ikavgo unauthorized: /override is restricted to Repo administrators.

In response to [this](https://github.com/knative-extensions/eventing-rabbitmq/pull/1370#issuecomment-2046051750): >/override "codecov/patch" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
knative-prow[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckyoog, ikavgo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/eventing-rabbitmq/blob/main/OWNERS)~~ [ikavgo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dprotaso commented 5 months ago

/override "codecov/patch"

knative-prow[bot] commented 5 months ago

@dprotaso: Overrode contexts on behalf of dprotaso: codecov/patch

In response to [this](https://github.com/knative-extensions/eventing-rabbitmq/pull/1370#issuecomment-2046076094): >/override "codecov/patch" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.