search

knative-extensions / eventing-redis

Redis integration with Knative Eventing.
Apache License 2.0
16 stars 28 forks source link

Socket error occurs when restarting Redis #387

Open tdeverdiere opened 2 years ago

tdeverdiere commented 2 years ago

Describe the bug In k8s cluster, when Redis is restarted eventing-redis use an old socket to connect and there is this error in logs: 

{"severity":"ERROR","timestamp":"2022-10-03T14:04:38.422117731Z","logger":"redis-stream-source","caller":"adapter/adapter.go:185","message":"Cannot read from stream","commit":"6becb00-dirty","stream":"vms:changes","error":"write tcp 10.6.4.171:58374->172.20.208.153:6379: use of closed network connection","stacktrace":"knative.dev/eventing-redis/source/pkg/adapter.(*Adapter).processEntry\n\tknative.dev/eventing-redis/source/pkg/adapter/adapter.go:185\nknative.dev/eventing-redis/source/pkg/adapter.(*Adapter).Start.func1\n\tknative.dev/eventing-redis/source/pkg/adapter/adapter.go:156"}

Expected behavior Eventing-redis should reopen a socket when the error is "use of closed network connection". Or may be we should use a pool of connection to handle those error.

To Reproduce Restart Redis in the k8s cluster

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

christophefromparis commented 1 year ago

/reopen

knative-prow[bot] commented 1 year ago

@christophefromparis: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to [this](https://github.com/knative-sandbox/eventing-redis/issues/387#issuecomment-1466253383): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
aavarghese commented 1 year ago

/remove-lifecycle stale

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

pierDipi commented 1 year ago

/remove-lifecycle stale

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

tdeverdiere commented 1 year ago

/remove-lifecycle stale

tdeverdiere commented 1 year ago

/reopen

knative-prow[bot] commented 1 year ago

@tdeverdiere: Reopened this issue.

In response to [this](https://github.com/knative-extensions/eventing-redis/issues/387#issuecomment-1792046134): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
github-actions[bot] commented 9 months ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

tdeverdiere commented 1 month ago

/reopen

knative-prow[bot] commented 1 month ago

@tdeverdiere: Reopened this issue.

In response to [this](https://github.com/knative-extensions/eventing-redis/issues/387#issuecomment-2406653521): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.