search

knative-extensions / kn-plugin-admin

Kn plugin for managing a Kubernetes based Knative installation.
Apache License 2.0
7 stars 18 forks source link

Failed to build kn-plugin-admin #10

Closed chaozbj closed 3 years ago

chaozbj commented 3 years ago

When we run release.sh or run go build in cmd folder, we got the following error:

../pkg/command/registry/list.go:27:2: cannot find package "." in:
    /Users/chao/Workspace/Code/github.com/knative/kn-plugin-admin/vendor/knative.dev/client-contrib/plugins/admin/pkg

I guess this is caused by module renaming, we may missed the codes in ongoing RP when we changed the module name. I will fix it soon.

chaozbj commented 3 years ago

/assign

zhanggbj commented 3 years ago

Thanks @chaozbj for opening this. Talked with Xin offline, This is caused by the lastest two merged PR 1) import path change 2) registry list (use old path) I'm raising PR now. https://github.com/knative-sandbox/kn-plugin-admin/pull/11

chaozbj commented 3 years ago

@zhanggbj Sorry, I just saw you have a PR to address it. I will close my RP.

zhanggbj commented 3 years ago

@chaozbj No worries. I'm trying to unblock others, but we need to wait for another review to merge it.

zhanggbj commented 3 years ago

@chaozbj this is fixed, would you please help to close it. Thanks!

chaozbj commented 3 years ago

/close