knative-extensions / kn-plugin-admin

Kn plugin for managing a Kubernetes based Knative installation.
Apache License 2.0
7 stars 18 forks source link

Added cluster domain claim commands #108

Closed vyasgun closed 3 years ago

vyasgun commented 3 years ago

Changes

Added create, delete, and list commands for cluster domain claim resource

Usage:

kn admin cdc create xyz.com --namespace test-ns
kn admin cdc delete xyz.com

/kind

Fixes #100

Release Note

Docs

knative-prow-robot commented 3 years ago

@vyasgun: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/knative-sandbox/kn-plugin-admin/pull/108): > > ># Changes >Added create, delete, and list commands for cluster domain claim resource > > >- For creating a domainmapping, the related cluster domain claim object needs to be created first. >- By adding this command, user doesn't have to switch to kubectl to create it. They can use `kn admin` commands for CDC management. >- TODO: Need to add unit/e2e tests > >Usage: > >``` >kn admin cdc create xyz.com --namespace test-ns >kn admin cdc delete xyz.com >``` > > >/kind > > >Fixes #100 > > > >**Release Note** > > >```release-note > >``` > >**Docs** > > >```docs > >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
codecov[bot] commented 3 years ago

Codecov Report

Merging #108 (4db0327) into main (0b2a78f) will increase coverage by 0.68%. The diff coverage is 88.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   79.98%   80.66%   +0.68%     
==========================================
  Files          20       24       +4     
  Lines        1029     1117      +88     
==========================================
+ Hits          823      901      +78     
- Misses        147      155       +8     
- Partials       59       61       +2     
Impacted Files Coverage Δ
pkg/types.go 19.64% <0.00%> (-2.36%) :arrow_down:
pkg/command/cdc/list.go 92.59% <92.59%> (ø)
pkg/command/cdc/create.go 92.85% <92.85%> (ø)
core/root.go 61.29% <100.00%> (+1.29%) :arrow_up:
pkg/command/cdc/cdc.go 100.00% <100.00%> (ø)
pkg/command/cdc/delete.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0b2a78f...4db0327. Read the comment docs.

rhuss commented 3 years ago

@vyasgun sorry, I'm late to this PR but plan to give it a review after the release. In the meantime, could you please resolve the conflicts ? thx!

vyasgun commented 3 years ago

I haven't added docs yet so adding the hold tag.

/hold

vyasgun commented 3 years ago

/hold

vyasgun commented 3 years ago

/unhold

dsimansk commented 3 years ago

Thanks!

/approve /lgtm

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, maximilien, vyasgun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-sandbox/kn-plugin-admin/blob/main/OWNERS)~~ [dsimansk,maximilien] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment