Closed vyasgun closed 3 years ago
@vyasgun: The label(s) kind/<kind>
cannot be applied, because the repository doesn't have them.
Merging #108 (4db0327) into main (0b2a78f) will increase coverage by
0.68%
. The diff coverage is88.63%
.
@@ Coverage Diff @@
## main #108 +/- ##
==========================================
+ Coverage 79.98% 80.66% +0.68%
==========================================
Files 20 24 +4
Lines 1029 1117 +88
==========================================
+ Hits 823 901 +78
- Misses 147 155 +8
- Partials 59 61 +2
Impacted Files | Coverage Δ | |
---|---|---|
pkg/types.go | 19.64% <0.00%> (-2.36%) |
:arrow_down: |
pkg/command/cdc/list.go | 92.59% <92.59%> (ø) |
|
pkg/command/cdc/create.go | 92.85% <92.85%> (ø) |
|
core/root.go | 61.29% <100.00%> (+1.29%) |
:arrow_up: |
pkg/command/cdc/cdc.go | 100.00% <100.00%> (ø) |
|
pkg/command/cdc/delete.go | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0b2a78f...4db0327. Read the comment docs.
@vyasgun sorry, I'm late to this PR but plan to give it a review after the release. In the meantime, could you please resolve the conflicts ? thx!
I haven't added docs yet so adding the hold tag.
/hold
/hold
/unhold
Thanks!
/approve /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dsimansk, maximilien, vyasgun
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Changes
Added create, delete, and list commands for cluster domain claim resource
kn admin
commands for CDC management.Usage:
/kind
Fixes #100
Release Note
Docs