search

knative-extensions / kn-plugin-admin

Kn plugin for managing a Kubernetes based Knative installation.
Apache License 2.0
7 stars 18 forks source link

Quick Fix for pkg import path #11

Closed zhanggbj closed 3 years ago

zhanggbj commented 3 years ago

This is caused by the lastest two merged PR 1) import path change 2) registry list (new added files but use old path)

zhanggbj commented 3 years ago

/lgtm Tring to merge it as this is urgent and is blocking others.

knative-prow-robot commented 3 years ago

@zhanggbj: you cannot LGTM your own PR.

In response to [this](https://github.com/knative-sandbox/kn-plugin-admin/pull/11#issuecomment-722301847): >/lgtm >Tring to merge it as this is urgent and is blocking others. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
zhanggbj commented 3 years ago

@maximilien @rhuss @navidshaikh would you please help to review and merge it, thanks!

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien, zhanggbj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-sandbox/kn-plugin-admin/blob/master/OWNERS)~~ [maximilien,zhanggbj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment