As a Knative administrator, I want to upate autoscaling configs(global) which apply to overall Knative platform.

knative-extensions / kn-plugin-admin

Kn plugin for managing a Kubernetes based Knative installation.

Apache License 2.0

7 stars 18 forks source link

As a Knative administrator, I want to upate autoscaling configs(global) which apply to overall Knative platform. #16

Closed zhanggbj closed 3 years ago

zhanggbj commented 3 years ago

The default setting will be consistent with values in knative doc

[x] Stable-window xx
[x] panic-window-percentage xx
[x] max-scale-up-rate xx
[x] container-concurrency-target-default xx
[x] container-concurrency-target-percentage xx
[x] requests-per-second-target-default xx
[x] target-burst-capacity
[x] panic-threshold-percentage
[x] max-scale-down-rate
[x] scale-to-zero-grace-period
[x] scale-to-zero-pod-retention-period
[x] pod-autoscaler-class
[x] activator-capacity

zhanggbj commented 3 years ago

/assign @rhuss /assign @maximilien /assign @navidshaikh
/assign @markusthoemmes Invited reviewers for code review, thanks!

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien, zhanggbj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-sandbox/kn-plugin-admin/blob/master/OWNERS)~~ [maximilien,zhanggbj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

markusthoemmes commented 3 years ago

Not quite sure I'm the right person to review stuff :thinking:

xliuxu commented 3 years ago

/lgtm