Closed chaozbj closed 3 years ago
/hold wait for #16 to merge first.
/unhold
@zhanggbj @maximilien Changes as below:
Following knative/client v0.17
to update go.mod
because I want to use autoscaler.Config.ScaleToZeroPodRetentionPeriod
field which is introduced from knative/serving v0.15.
I didn't follow the knative/client v0.18 or v0.19
to update go.mod
since I got compiling error when I use k8s.io/apimachinery >= v0.18
, there is an interface changed from v0.18(maybe from earlier version):
../pkg/command/utils/utils.go:27:72: not enough arguments in call to client.CoreV1().ConfigMaps(desiredCm.ObjectMeta.Namespace).Get
have (string, "k8s.io/apimachinery/pkg/apis/meta/v1".GetOptions)
want (context.Context, string, "k8s.io/apimachinery/pkg/apis/meta/v1".GetOptions)
We need to change our codes if we want to adopt it, but I don't want to address them in this PR, so I choosed the older version to use.
Always list all values for autoscaler configs, if the config is changed by user, the user's value will be printed, otherwise the default value will be printed. I called autoscalerconfig.NewConfigFromMap(map[string]string)
defined in knative/serving to build configs with default value, that is why I need to update go.mod
.
Updated unit test codes for new changes.
Added e2e test case for autoscaling list
command.
A minor change for release.sh
, using -mod=readonly
to replace-mod=vendor
because we don't use vendor now.
Please help me to review, thanks!
@chaozbj Thanks Chao for the efforts! In general, the changes look good to me,
For 1) Let's finish the dependency bump firstly in PR https://github.com/knative-sandbox/kn-plugin-admin/pull/21, we need it to build release 0.1.0, this will also resolve the issue you mentioned.
For 5) I think ./hack/xx
is more proper for some scripts and tools like release.sh
@zhanggbj I rebased it from PR #25 and also deleted release.sh
script because I found that hack/build.sh
can do the same thing. Please help me review, thanks!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: chaozbj, maximilien, zhanggbj
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm Look nice and merging! Thanks @chaozbj!
Prow tests are failing due to test-infra setting in progress which is covered by https://github.com/knative-sandbox/kn-plugin-admin/pull/24
/usr/local/bin/kubekins-runner.sh: line 104: ./test/presubmit-tests.sh: No such file or directory
/test all
/retest
/lgtm cancel
@chaozbj would you please help to rebase first. Just merged Navid's PR for test infra.
/retest
/retest
@chaozbj : there is a verify codegen step now part of the build tests,
ERROR: /home/prow/go/src/knative.dev/kn-plugin-admin is out of date. Please run ./hack/build.sh -c and commit.
--
please run ./hack/build.sh
and commit the changes
@chaozbj: The following tests failed, say /retest
to rerun all failed tests:
Test name | Commit | Details | Rerun command |
---|---|---|---|
pull-knative-sandbox-kn-plugin-admin-build-tests | 4e4a2b402ca31f572a7a25a882a141298bcd9989 | link | /test pull-knative-sandbox-kn-plugin-admin-build-tests |
pull-knative-sandbox-kn-plugin-admin-integration-tests | 4e4a2b402ca31f572a7a25a882a141298bcd9989 | link | /test pull-knative-sandbox-kn-plugin-admin-integration-tests |
Full PR test history. Your PR dashboard.
close it and will create a new PR for autoscaling list
command
The issue is: #15 here is an example of output: