search

knative-extensions / kn-plugin-admin

Kn plugin for managing a Kubernetes based Knative installation.
Apache License 2.0
7 stars 18 forks source link

report error if build kn-plugin-admin without kubeconfig specified #19

Closed zhanggbj closed 3 years ago

zhanggbj commented 3 years ago

If no kubeconfig specified, there's an error msg while go build, looks like it is for operater mod, please help to take a look, thanks!

[zhanggong@zhanggongdeMacBook-Pro kn-plugin-admin (as_pr_final ✗)]$ ./hack/build.sh   
🚒 Update
✋ No 'goimports' found. Please use
✋   go install golang.org/x/tools/cmd/goimports
✋ to enable import cleanup. Import cleanup skipped.
🧹 Format
⚖️ License
🚧 Compile
🧪 Test
────────────────────────────────────────────
failed to get installation method: Get "https://192.168.99.102:8443/api/v1/namespaces/knative-serving/configmaps/config-domain": dial tcp 192.168.99.102:8443: i/o timeout
zhanggbj commented 3 years ago

/assign @lanceliuu /kind bug /label 0.1.0releasee

knative-prow-robot commented 3 years ago

@zhanggbj: The label(s) /label 0.1.0releasee cannot be applied. These labels are supported: proposal/0.11, proposal/0.12, proposal/0.13, proposal/0.14, proposal/0.15, proposal/0.16, proposal/0.17, proposal/0.18, proposal/0.19, channel/kafka, channel/natss, source/awssqs, source/camel, source/ceph, source/couchdb, source/github, source/kafka, source/prometheus

In response to [this](https://github.com/knative-sandbox/kn-plugin-admin/issues/19#issuecomment-731057947): >/assgin @lanceliuu >/kind bug >/label 0.1.0releasee > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
zhanggbj commented 3 years ago

/assign @lanceliuu

knative-prow-robot commented 3 years ago

@zhanggbj: GitHub didn't allow me to assign the following users: lanceliuu.

Note that only knative-sandbox members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/knative-sandbox/kn-plugin-admin/issues/19#issuecomment-731064088): >/assign @lanceliuu Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
xliuxu commented 3 years ago

I cannot reproduce the error. Could you help to provide more details? I have no KUBECONFIG or other context defined while testing.

🚒 Update
✋ No 'goimports' found. Please use
✋   go install golang.org/x/tools/cmd/goimports
✋ to enable import cleanup. Import cleanup skipped.
🧹  Format
⚖️  License
🚧 Compile
🧪 Test
────────────────────────────────────────────
Version:      v20201122-local-e1f827b-dirty
Build Date:   2020-11-22 14:22:08
Git Revision: e1f827b
chaozbj commented 3 years ago

No sure if it has the same root cause with the #32, I actually addressed #32 in our old repository, maybe we lost these changes when we moved it to the new repository. I will keep eye on it when I fix the #32 issue.

zhanggbj commented 3 years ago

/assign @chaozbj Merged!