knative-extensions / kn-plugin-admin

Kn plugin for managing a Kubernetes based Knative installation.
Apache License 2.0
7 stars 18 forks source link

Upgrade Go to 1.17 #209

Closed dsimansk closed 2 years ago

dsimansk commented 2 years ago

Follow-up on Client go version upgrade.

Changes

/cc @maximilien @rhuss @vyasgun

codecov[bot] commented 2 years ago

Codecov Report

Merging #209 (bafef91) into main (fc2f88d) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #209   +/-   ##
=======================================
  Coverage   78.95%   78.95%           
=======================================
  Files          24       24           
  Lines        1459     1459           
=======================================
  Hits         1152     1152           
  Misses        245      245           
  Partials       62       62           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fc2f88d...bafef91. Read the comment docs.

knative-prow[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, maximilien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-sandbox/kn-plugin-admin/blob/main/OWNERS)~~ [dsimansk,maximilien] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
maximilien commented 2 years ago

Any chance to rebase @dsimansk ?

dsimansk commented 2 years ago

@maximilien done, sorry for the delay.

dsimansk commented 2 years ago

@maximilien or @vyasgun if you could take a look please. I've put auto-update PR on hold to avoid conflicts this time. :)

vyasgun commented 2 years ago

/lgtm