Closed navidshaikh closed 3 years ago
/test all
/cc @zhanggbj This is ready to merge, now e2e tests are being run as well. Note that I've pinned serving/eventing versions to v0.19.x, update it as required.
There is another part remaining to wire /hack/update-codegen.sh
with ./hac/build.sh
where I am constantly getting
Error: one or more libraries have an incompatible/unknown license: map["unknown":["knative.dev/kn-plugin-admin/pkg" "knative.dev/kn-plugin-admin/pkg/command" "knative.dev/kn-plugin-admin/pkg/command/utils" "knative.dev/kn-plugin-admin/pkg/command/autoscaling" "knative.dev/kn-plugin-admin/pkg/command/domain" "knative.dev/kn-plugin-admin/pkg/command/profiling" "knative.dev/kn-plugin-admin/pkg/command/registry" "knative.dev/kn-plugin-admin/core" "knative.dev/kn-plugin-admin/cmd" "knative.dev/kn-plugin-admin/pkg/testutil"]]
I will work on it part of separate PR, but configured set of jobs should be good enough to test the existing PRs and unblock merging. cc: @rhuss
There is another part remaining to wire /hack/update-codegen.sh with ./hac/build.sh where I am constantly getting
This is fixed now, LICENSE was missing in the repo. Thanks to @chizhg for the hint!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: navidshaikh, zhanggbj
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm Thanks @navidshaikh, looks great! Finally, we have tests running again!