knative-extensions / kn-plugin-admin

Kn plugin for managing a Kubernetes based Knative installation.

Apache License 2.0

7 stars 18 forks source link

update module dependency to latest version #25

Closed zhi-gang-sun closed 3 years ago

zhi-gang-sun commented 3 years ago

Changes

broom - - -

/kind api-change

Fixes #20

Release Note

Docs

knative-prow-robot commented 3 years ago

@zhi-gang-sun: The label(s) kind/<kind>cleanup cannot be applied, because the repository doesn't have them

In response to [this](https://github.com/knative-sandbox/kn-plugin-admin/pull/25): > > ># Changes > >broom > >- >- >- > > >/kind cleanup > > >Fixes #20 > > > >**Release Note** > > >```release-note > >``` > >**Docs** > > >```docs > >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

zhi-gang-sun commented 3 years ago

Local build log:

zhi-gang-sun commented 3 years ago

@zhanggbj @chaozbj please take a look the changes as well when you get chance, thanks!

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhanggbj, zhi-gang-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-sandbox/kn-plugin-admin/blob/master/OWNERS)~~ [zhanggbj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

zhanggbj commented 3 years ago

/lgtm Thanks @zhi-gang-sun for your PR and @chaozbj for helping with it. Merging it 👍